Improve Prop Change/State Update#784
Merged
ryanlanciaux merged 6 commits intoGriddleGriddle:masterfrom Dec 24, 2017
Merged
Conversation
ryanlanciaux
approved these changes
Dec 24, 2017
Member
ryanlanciaux
left a comment
ryanlanciaux
left a comment
There was a problem hiding this comment.
This is great. Thank you
Member
|
Verified (smoke test on some of my bigger projects) and published!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Griddle major version
1.11
Changes proposed in this pull request
Fixes #781 root cause (cc @sum32)
GRIDDLE_UPDATE_STATEand adjusted its behavior a bit (e.g. not losingdata).actions.updateStateto pass all state through, instead of onlydata,pagePropertiesandsortProperties. That limitation was introduced by @joellanciaux way back in Controlled Griddle component #505, but it's not obvious why.<Griddle />prop), which I ultimately expanded to demonstrate changing several<Griddle />props, includingdataandstyleConfig.Why these changes are made
Changes to props should be reflected in Griddle's store and its rendering.
Are there tests?
Tests and stories!